[PATCH] D22726: [DAGCombine] Match shift amount by value rather than relying on common sub-expressions.

[bryant via llvm-commits]

bryant marked 4 inline comments as done.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4866
@@ -4860,3 +4865,3 @@
     }
   }
 
----------------
Yeah, I read a bit too quickly. Please disregard. The transform is now generalized to up to 2**64 - 1 _in width_.

Also, for efficiency's sake, I think it might be better for `c0` and `c1` and their subsequent comparison and other operations to be `uint64_t`, since they're ultimately restricted to that value range anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D22726