[PATCH] D22143: [SimplifyCFG] Rewrite SinkThenElseCodeToEnd

[James Molloy via llvm-commits]

jmolloy closed this revision.
jmolloy added a comment.

Thanks Sanjoy - committed with your suggestions in r278660!


================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:1337
@@ +1336,3 @@
+  if (!I0->mayReadOrWriteMemory())
+    return true;
+
----------------
sanjoy wrote:
> This one wasn't addressed.
This is never called for alloca instructions. There is a known set of semantics-breaking instructions pruned out in line 1389.


Repository:
  rL LLVM

https://reviews.llvm.org/D22143