[PATCH] D22726: [DAGCombine] Match shift amount by value rather than relying on common sub-expressions.

bryant via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 14 13:45:40 PDT 2016


bryant added a comment.

In https://reviews.llvm.org/D22726#513819, @spatel wrote:

> The problem summary notes that this fold is missing from InstCombine. Would we sidestep the later questions (and possibly target-specific problems) by doing the transform in IR?


I'm totally open to doing this in InstCombine, hence making the note in the first place.

> Side note: bryant, your handle seems to have broken the internet :) -

>  http://lists.llvm.org/pipermail/llvm-dev/2016-August/103596.html


Thanks (: I've reached out to Cameron and fixed the issue.


Repository:
  rL LLVM

https://reviews.llvm.org/D22726





More information about the llvm-commits mailing list