[PATCH] D23486: [llvm-cov] Add coverage summary information to the HTML index page.
Richard Pennington via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 13 20:52:38 PDT 2016
rdp marked 5 inline comments as done.
rdp added a comment.
This is my first time using Phabricator. I hope I updated the review properly.
================
Comment at: SourceCoverageViewHTML.cpp:213
@@ -211,1 +212,3 @@
+ const std::string &PathToStyle = "",
+ bool trAlternate = false) {
OS << "<!doctype html>"
----------------
I think I understand, but I'm not an HTML/CSS expert. I think I want the CSSForCoverage used for every page, and the AlternateRowColor added for just the index page. Are you suggesting that getCSSForCoverage return the string for the entire CSS?
https://reviews.llvm.org/D23486
More information about the llvm-commits
mailing list