[PATCH] D22719: MachineFunction: Introduce NoPHIs property

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 18:30:15 PDT 2016


qcolombet added inline comments.

================
Comment at: lib/CodeGen/RegAllocBase.cpp:65
@@ +64,3 @@
+             MachineFunctionProperties::Property::NoPHIs)
+         && "PHI instructions not supported");
+  MRI->freezeReservedRegs(MF);
----------------
Use the getRequiredProperties method that are built in the machine function passes instead of an assert.

================
Comment at: lib/CodeGen/RegAllocFast.cpp:1094
@@ -1092,2 +1093,3 @@
+         && "PHI instructions not supported");
 
   // initialize the virtual->physical register map to have a 'null'
----------------
Ditto.

================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:429
@@ -428,1 +428,3 @@
+             MachineFunctionProperties::Property::NoPHIs) &&
+         "PHI instructions not supported");
 
----------------
Ditto.


Repository:
  rL LLVM

https://reviews.llvm.org/D22719





More information about the llvm-commits mailing list