[PATCH] D23447: [ELF] - Do not use mergeable sections when LS is used.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 12:28:53 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D23447#514076, @ruiu wrote:

> But the problem you are trying to fix is a hard one in my opinion. Currently, we instantiate input sections when we read them from files, so the decision whether the sections are to be string-merged or not is made when we read files. That's too early if you allow linker scripts to combine non-mergeable sections with mergeable ones. I do not have a clear idea how to deal with this. If you have an idea, and if it's going to be a large change, please discuss before writing a patch.


Yep, I also today faced it is not trivial task. At first I thought it is possible to convert mergable section to regular, but probably better would be to create regular ones at the begining. 
I have no good ideas how to do that without early sections scan. Will revisit this later.


https://reviews.llvm.org/D23447





More information about the llvm-commits mailing list