[llvm] r278539 - Hide type trait from r278532 from MSVC

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 11:10:29 PDT 2016


Author: dexonsmith
Date: Fri Aug 12 13:10:29 2016
New Revision: 278539

URL: http://llvm.org/viewvc/llvm-project?rev=278539&view=rev
Log:
Hide type trait from r278532 from MSVC

The fixup from r278537 was insufficient.  Just #ifdef it out for MSVC.

Modified:
    llvm/trunk/include/llvm/ADT/ilist.h

Modified: llvm/trunk/include/llvm/ADT/ilist.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ilist.h?rev=278539&r1=278538&r2=278539&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ADT/ilist.h (original)
+++ llvm/trunk/include/llvm/ADT/ilist.h Fri Aug 12 13:10:29 2016
@@ -390,8 +390,12 @@ template<typename NodeTy> struct simplif
 ///
 template <typename NodeTy, typename Traits = ilist_traits<NodeTy>>
 class iplist : public Traits, ilist_node_access {
+#if !defined(_MSC_VER)
+  // FIXME: This fails in MSVC, but it's worth keeping around to help
+  // non-Windows users root out bugs in their ilist_traits.
   static_assert(!ilist_detail::HasGetNext<Traits, NodeTy>::value,
                 "ilist next and prev links are not customizable!");
+#endif
 
   mutable NodeTy *Head;
 




More information about the llvm-commits mailing list