[PATCH] D23352: [ELF] - Linkerscript: implemented simple heuristic for placing orphan sections.

[George Rimar via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D23352#513092, @ruiu wrote:

> I imagine that if you want to implement a logic for orphan sections, you want to implement the same rule for the non-linker-script case. I'ts hard to review because there are many patches on the fly. I'm wondering how this change will relate to https://reviews.llvm.org/D23315.


Sorry, but I don't understand the idea I think. Why we would want to implement the same rule as we have for non-script case ? 
In non-script case there is no oprhans, sections just grouped together by attributes. When script is present, sections should be placed
in a order specified by script. That violates the non-scripted rule. 
This patch places orphans to be in group with the sections with the same attributes. So here it is close to what non-scripted case do.
The only difference that script has a priority against any other rules and that is what expected I think.

I guess https://reviews.llvm.org/D23315 is no more actual, I am going to rebase and update this one soon.


https://reviews.llvm.org/D23352