[PATCH] D20268: Resolution-based LTO API.
Roger Ferrer Ibanez via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 12 01:07:41 PDT 2016
rogfer01 added a subscriber: rogfer01.
================
Comment at: llvm/trunk/tools/gold/gold-plugin.cpp:95
@@ +94,3 @@
+ bool VisibleToRegularObj = false;
+ uint64_t Size = 0;
+ unsigned Align = 0;
----------------
I think this one should be `size_t` as `lto::InputFile::Symbol::getCommonSize` returns `size_t` and then the `std::max` in line 629 fails to build in targets where `size_t` is `unsigned int`.
Can you confirm if changing to `size_t` makes sense here? It does fix the build indeed.
If this is OK I can commit the change.
Repository:
rL LLVM
https://reviews.llvm.org/D20268
More information about the llvm-commits
mailing list