[PATCH] D22932: Implement llvm-objdump -S and -l

[Saleem Abdulrasool via llvm-commits]

compnerd added inline comments.

================
Comment at: test/tools/llvm-objdump/X86/Inputs/source-interleave-x86_64.c:11
@@ +10,2 @@
+  return *b + foo();
+}
----------------
Might be nice to clang-format this file before checkin.  It hurts my sense of aesthetics :-p.

================
Comment at: test/tools/llvm-objdump/X86/source-interleave.s:5
@@ +4,3 @@
+// RUN: llvm-objdump -d -S %t.o | FileCheck --check-prefix="SOURCE" %t.s
+
+	.text
----------------
Is there a reason to prefer ASM over LLVM IR here?  If we use LLVM IR, it might be much shorter.  Since the DI should reference the LineNumber, I think that the test output should be consistent.


Repository:
  rL LLVM

https://reviews.llvm.org/D22932