[PATCH] D23431: Remove redundant pointer map lookup

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 15:52:28 PDT 2016


mkuper requested changes to this revision.
mkuper added a comment.
This revision now requires changes to proceed.

It looks like this is on purpose:

https://reviews.llvm.org/rL68047
"getEntryFor() may invalidate DenseMap iterator.
Walking an invalidated iterator is not a good idea."

I think this is still true, but we should probably add a comment.


https://reviews.llvm.org/D23431





More information about the llvm-commits mailing list