[llvm] r278170 - Add a platform independent version of __PRETTY_FUNCTION__.
Zachary Turner via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 11 14:28:44 PDT 2016
Ahh, yea I thought I was using LLVM_ON_WIN32 instead of _MSC_VER, but it
turns out I'm using _MSC_VER. TBH I will defer to you guys, I'm not an
expert on all the different platforms and their configurations /
definitions. If having __clang__ is at worst redundant, seems like it
wouldn't hurt to leave it and be on the safe side, but if someone out there
is absolutely sure it's not necessary I can remove it.
On Thu, Aug 11, 2016 at 12:03 PM Joerg Sonnenberger via llvm-commits <
llvm-commits at lists.llvm.org> wrote:
> On Thu, Aug 11, 2016 at 06:35:42PM +0000, Zachary Turner wrote:
> > No (just tested on windows with the cl driver and with the gcc style
> > driver). If you were to do this on Windows it wouldn't matter because
> that
> > would be caught by the first branch #if defined(LLVM_ON_WIN32). But you
> > can run clang in Microsoft on Linux, for example. And in that case
> neither
> > LLVM_ON_WIN32 nor __GNUC__ would be defined.
>
> But don't we hit the _MSC_VER case in that case?
>
> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160811/08252d96/attachment.html>
More information about the llvm-commits
mailing list