[lld] r278398 - Arm64 stubs alignment is 2, not 4.

Pete Cooper via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 13:18:06 PDT 2016


Author: pete
Date: Thu Aug 11 15:18:05 2016
New Revision: 278398

URL: http://llvm.org/viewvc/llvm-project?rev=278398&view=rev
Log:
Arm64 stubs alignment is 2, not 4.

This matches the behaviour of ld64 when looking at the alignment of the stubs section in the final image.

Modified:
    lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp
    lld/trunk/test/mach-o/hello-world-arm64.yaml

Modified: lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp?rev=278398&r1=278397&r2=278398&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp Thu Aug 11 15:18:05 2016
@@ -275,8 +275,8 @@ const ArchHandler::StubInfo ArchHandler_
   // GOT pointer to dyld_stub_binder
   { Reference::KindArch::AArch64, pointer64, 0, 0 },
 
-  // arm64 code alignment 2^2
-  2,
+  // arm64 code alignment 2^1
+  1,
 
   // Stub size and code
   12,

Modified: lld/trunk/test/mach-o/hello-world-arm64.yaml
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/mach-o/hello-world-arm64.yaml?rev=278398&r1=278397&r2=278398&view=diff
==============================================================================
--- lld/trunk/test/mach-o/hello-world-arm64.yaml (original)
+++ lld/trunk/test/mach-o/hello-world-arm64.yaml Thu Aug 11 15:18:05 2016
@@ -92,3 +92,10 @@ undefined-symbols:
 # CHECK:	(undefined) external _fprintf (from libSystem)
 # CHECK:	(undefined) external dyld_stub_binder (from libSystem)
 # CHECK:	{{[0-9a-f]+}} (__TEXT,__text) external _main
+
+# CHECK-PRIVATE-HEADER: sectname __stubs
+# CHECK-PRIVATE-HEADER-NEXT:  segname __TEXT
+# CHECK-PRIVATE-HEADER-NEXT:     addr 
+# CHECK-PRIVATE-HEADER-NEXT:     size 
+# CHECK-PRIVATE-HEADER-NEXT:   offset 
+# CHECK-PRIVATE-HEADER-NEXT:    align 2^1 (2)




More information about the llvm-commits mailing list