[PATCH] D23398: [XRay] Synthesize a reference to the xray_instr_map

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 10:45:12 PDT 2016


mehdi_amini added inline comments.

================
Comment at: test/CodeGen/X86/xray-attribute-instrumentation.ll:2
@@ -1,2 +1,3 @@
 ; RUN: llc -filetype=asm -o - -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck %s
+; RUN: llc -filetype=asm -o - -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck --check-prefix=CHECK-LABEL %s
 
----------------
I don't understand this line, this is the same run as the first line, but for the check-prefix. The intent is not clear. 
Note that "CHECK" is the default prefix, used by the first run. But "-LABEL" is a "magic" suffix for FileCheck. So "CHECK-LABEL" is already used by the first check!
See `The “CHECK-LABEL:” directive` section here: http://llvm.org/docs/CommandGuide/FileCheck.html


https://reviews.llvm.org/D23398





More information about the llvm-commits mailing list