[polly] r277263 - Extend the jscop interface to allow the user to declare new arrays and to reference these arrays from access expressions

[Roman Gareev via llvm-commits]

Hi Michael,

thanks for the comments!

2016-08-10 20:27 GMT+05:00 Michael Kruse <llvm-commits at meinersbur.de>:
> 2016-07-30 11:25 GMT+02:00 Roman Gareev via llvm-commits
> <llvm-commits at lists.llvm.org>:
>
>> --- polly/trunk/test/Isl/CodeGen/MemAccess/create_arrays.ll (added)
>> +; CHECK:    Arrays {
>> +; CHECK:        double E[*][270336][200000]; // Element size 8
>
>> --- polly/trunk/test/Isl/CodeGen/MemAccess/create_arrays___%bb9---%bb26.jscop (added)
>> +      {
>> +         "name" : "E",
>> +         "sizes" : [ "270336", "200000" ],
>> +         "type" : "double"
>> +      },
>
>> +   "statements" : [
>> +      {
>> +         "accesses" : [
>> +            {
>> +               "kind" : "read",
>> +               "relation" : "{ Stmt_bb12[i0, i1, i2] -> E[i2, i0] }"
>> +            },
>> +            {
>
> Hi just noticed some problem here. The array "E" is generated with
> three dimensions (with the first one unsized), but the array access is
> changed to only a two-dimensional one.

Сould we change the array access to three-dimensional one (e.g. "{
Stmt_bb12[i0, i1, i2] -> E[0, i2, i0] }")?

> The array's isl_id is named "E" (not "MemRef_E"). We will get a name
> clash when introducing an array named "MemRef_A", clashing with the
> already existing array A.

Could you explain why we get a name clash in this case? I thought that
if there is already an array named "A" and we introduce an array named
"MemRef_A", a new array named "MemRef_A" will be created.

Do you mean that it's better to add prefix "MemRef_" to names of all
arrays added in a JSCoP?

-- 
                                    Cheers, Roman Gareev.