[PATCH] D23326: [ELF] - Linkerscript: reimplemented output sections constrains matching functionality.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 11 02:40:51 PDT 2016
grimar added inline comments.
================
Comment at: ELF/LinkerScript.cpp:174
@@ -163,3 +173,3 @@
for (auto &P : getSectionMap()) {
- StringRef OutputName = P.first;
+ StringRef OutputName = P.first->Name;
const InputSectionDescription *Cmd = P.second;
----------------
ruiu wrote:
> I cannot infer `P.first`'s class from this local context. Please create a temporary varaible
>
> OutputSectionCommand *Cmd = P.first;
>
> to make it obvious.
Gone after rebasing.
https://reviews.llvm.org/D23326
More information about the llvm-commits
mailing list