[PATCH] D23342: [SCEV] Update interface to handle SCEVExpander insert point motion.

[Sanjoy Das via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm, but at this point I'm wondering if there is something we can do to rule out this class of bugs.  Any ideas @gberry?  Or is the solution here just "be careful when using SCEVExpander".


================
Comment at: test/Transforms/LoopStrengthReduce/X86/pr28719.ll:10
@@ +9,3 @@
+
+; Just make sure we don't generate code with uses not dominated by defs.
+define i32 @main() {
----------------
Can you still please add a `CHECK` for something obvious, like `CHECK-LABEL: @main(` ?


https://reviews.llvm.org/D23342