[PATCH] D23326: [ELF] - Linkerscript: reimplemented output sections constrains matching functionality.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 18:30:37 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:174
@@ -163,3 +173,3 @@
   for (auto &P : getSectionMap()) {
-    StringRef OutputName = P.first;
+    StringRef OutputName = P.first->Name;
     const InputSectionDescription *Cmd = P.second;
----------------
I cannot infer `P.first`'s class from this local context. Please create a temporary varaible

  OutputSectionCommand *Cmd = P.first;

to make it obvious.


https://reviews.llvm.org/D23326





More information about the llvm-commits mailing list