[PATCH] D23220: Make TwoAddressInstructionPass::rescheduleMIBelowKill subreg-aware

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 17:20:43 PDT 2016


MatzeB added a comment.

In https://reviews.llvm.org/D23220#512075, @mkuper wrote:

> In https://reviews.llvm.org/D23220#512070, @MatzeB wrote:
>
> > I guess you can use a SmallVector now if all you do is iterating over all elements of the container.
>
>
> I guess you're right. I left it as a set to avoid duplicates, but we shouldn't have those anyway, at least not in the common case.


There can be duplicates, but they shouldn't hurt. And it is probably more expensive to filter out the duplicates than just checking a register twice in the few cases where we actually have a duplicate.


https://reviews.llvm.org/D23220





More information about the llvm-commits mailing list