[PATCH] D22742: Fix `-jobs=<N>` where <N> > 1 and the number of workers is > 1 on macOS.

[Dan Liew via llvm-commits]

delcypher added inline comments.

================
Comment at: lib/Fuzzer/FuzzerUtilDarwin.cpp:89-94
@@ +88,8 @@
+  // following signals rather than inheriting what the parent has.
+  (void)sigaddset(&DefaultSigSet, SIGQUIT);
+  (void)sigaddset(&DefaultSigSet, SIGINT);
+  (void)posix_spawnattr_setsigdefault(&SpawnAttributes, &DefaultSigSet);
+  // Make sure the child process doesn't block SIGCHLD
+  (void)posix_spawnattr_setsigmask(&SpawnAttributes, &OldBlockedSignalsSet);
+  (void)posix_spawnattr_setflags(&SpawnAttributes, SpawnFlags);
+
----------------
kubabrecka wrote:
> Not a huge fan of the "(void)" prefixes.  I understand why you put them there, but no other code in libFuzzer seems to be using them.  Does this really produce any warnings?
@kubabrecka: They are not here to suppress warnings (warnings don't seem to be emitted by clang without them). They are here explicitly state that I intend to ignore the return value.

You are right that the rest of LibFuzzer isn't written in this style. I don't mind removing them though.
@kcc: Do you have a preference here?


https://reviews.llvm.org/D22742