[PATCH] D23339: Don't import variadic functions

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:733
@@ +732,3 @@
+  bool HasSection = RawFlags & 0x1;
+  bool IsViableToInline = RawFlags & 0x2;
+  return GlobalValueSummary::GVFlags(Linkage, HasSection, IsViableToInline);
----------------
Prazek wrote:
> mehdi_amini wrote:
> > Isn't it reversed here? The bit set to one is *not* viable to inline if I read correctly the writer counterpart.
> > There is something I'm probably missing, otherwise how's the test passing?
> good catch, I just forgot to change this name. I firstly wanted to make flag "IsViableToInline", but then because this bit changed from 0 to 1, most tests were invalid.
> I talked with Teresa and she said that it will be better to make this flag reverse, so it won't be set in most cases.
So right now the test is *not* passing right? (Probably none of the ThinLTO test should pass with this)


https://reviews.llvm.org/D23339