[PATCH] D23339: Don't import variadic functions

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 14:10:38 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:733
@@ +732,3 @@
+  bool HasSection = RawFlags & 0x1;
+  bool IsViableToInline = RawFlags & 0x2;
+  return GlobalValueSummary::GVFlags(Linkage, HasSection, IsViableToInline);
----------------
Isn't it reversed here? The bit set to one is *not* viable to inline if I read correctly the writer counterpart.
There is something I'm probably missing, otherwise how's the test passing?


https://reviews.llvm.org/D23339





More information about the llvm-commits mailing list