[PATCH] D23374: Fix typo in lowering for fp128 ueq

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 13:59:05 PDT 2016


efriedma created this revision.
efriedma added reviewers: t.p.northover, hfinkel, petarj.
efriedma added a subscriber: llvm-commits.
efriedma set the repository for this revision to rL LLVM.

Regression from r259791.

Repository:
  rL LLVM

https://reviews.llvm.org/D23374

Files:
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  test/CodeGen/AArch64/arm64-fp128.ll

Index: test/CodeGen/AArch64/arm64-fp128.ll
===================================================================
--- test/CodeGen/AArch64/arm64-fp128.ll
+++ test/CodeGen/AArch64/arm64-fp128.ll
@@ -156,6 +156,28 @@
 ; CHECK: ret
 }
 
+define i1 @test_setcc3() {
+; CHECK-LABEL: test_setcc3:
+
+  %lhs = load fp128, fp128* @lhs, align 16
+  %rhs = load fp128, fp128* @rhs, align 16
+; CHECK: ldr q0, [{{x[0-9]+}}, :lo12:lhs]
+; CHECK: ldr q1, [{{x[0-9]+}}, :lo12:rhs]
+
+  %val = fcmp ueq fp128 %lhs, %rhs
+; CHECK: bl __eqtf2
+; CHECK: cmp     w0, #0
+; CHECK: cset    w19, eq
+; CHECK: bl __unordtf2
+; CHECK: cmp     w0, #0
+; CHECK: cset    w8, ne
+; CHECK: orr     w0, w8, w19
+
+  ret i1 %val
+; CHECK: ret
+}
+
+
 define i32 @test_br_cc() {
 ; CHECK-LABEL: test_br_cc:
 
Index: lib/CodeGen/SelectionDAG/TargetLowering.cpp
===================================================================
--- lib/CodeGen/SelectionDAG/TargetLowering.cpp
+++ lib/CodeGen/SelectionDAG/TargetLowering.cpp
@@ -216,7 +216,7 @@
   case ISD::SETUEQ:
     LC1 = (VT == MVT::f32) ? RTLIB::UO_F32 :
           (VT == MVT::f64) ? RTLIB::UO_F64 :
-          (VT == MVT::f128) ? RTLIB::UO_F64 : RTLIB::UO_PPCF128;
+          (VT == MVT::f128) ? RTLIB::UO_F128 : RTLIB::UO_PPCF128;
     LC2 = (VT == MVT::f32) ? RTLIB::OEQ_F32 :
           (VT == MVT::f64) ? RTLIB::OEQ_F64 :
           (VT == MVT::f128) ? RTLIB::OEQ_F128 : RTLIB::OEQ_PPCF128;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23374.67598.patch
Type: text/x-patch
Size: 1418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160810/6f05dd42/attachment.bin>


More information about the llvm-commits mailing list