[PATCH] D23351: [ELF] Implement LLVM-style casting for OutputSectionBase<ELFT> derived classes

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.

================
Comment at: ELF/OutputSections.h:52
@@ +51,3 @@
+  enum Kind {
+    Base,
+    BuildId,
----------------
ruiu wrote:
> I don't think we need `Base` because all OutputSectionBases are of Base class. You'll never need to do cast<OutputSectionBase<ELFT>>(P).
Out<ELFT>::ProgramHeaders are of type OutputSectionBase<ELFT>, so I can't make getKind() pure virtual in this class.



https://reviews.llvm.org/D23351