[PATCH] D23286: AMDGPU/SI: Propose to redefine image load/store intrinsics

Changpeng Fang via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 10:51:13 PDT 2016


cfang added a comment.

In https://reviews.llvm.org/D23286#511221, @mareko wrote:

> > if you use v8i32 as rsrc type, then r128 is true!
>
>
> Also, the quoted sentence is non-sense. In 100% of our cases, r128 must be 0.


Yes, the quoted comment is wrong. Do you think I can drop r128 bit support?
i.e. set resource type to be v8i32 and r128 bit to be 0 all the time?

I heard GL somehow uses R128 bit.


https://reviews.llvm.org/D23286





More information about the llvm-commits mailing list