[llvm] r278002 - [AArch64] PR28877: Don't assume we're running after legalization when creating vcvtfp2fxs

via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 09:17:52 PDT 2016


FWIW, this fixes PR28617, which is marked as a 3.9 release blocker.

I wrote the original combine and the change seems reasonable for 
inclusion in 3.9, IMHO.

  Chad

On 2016-08-09 17:54, Tim Northover via llvm-commits wrote:
> On 9 August 2016 at 14:26, Hans Wennborg <hans at chromium.org> wrote:
>> Since someone ran into this with real code, perhaps we should consider
>> to merge it?
>> 
>> Tim, Renato: what do you think?
> 
> It seems like a strict improvement, though a bit oddly written (v4i64
> is never legal on AArch64). I also suspect performFDivCombine is
> similarly affected for the int -> float conversion.
> 
> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list