[PATCH] D23321: [sancov] Port sancov -print-coverage-pcs to COFF

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 09:08:40 PDT 2016


rnk added a comment.

In https://reviews.llvm.org/D23321#510427, @kcc wrote:

> code almost LG,
>  not an expert in lit part. Anyone else?


The lit part is pretty trivial. I'm comfortable landing if you like and stamp the sancov part.


================
Comment at: tools/sancov/sancov.cc:355
@@ +354,3 @@
+
+      if (Name == "__sanitizer_cov" || Name == "__sanitizer_cov_with_check" ||
+          Name == "__sanitizer_cov_trace_func_enter") {
----------------
kcc wrote:
> don't copy-paste this if statement, move it into a separate function instead. 
Done


https://reviews.llvm.org/D23321





More information about the llvm-commits mailing list