[PATCH] D21809: [SystemZ] Add support for the .insn directive

[Zhan Jun Liau via llvm-commits]

zhanjunl added inline comments.

================
Comment at: llvm/trunk/lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp:512-520
@@ +511,11 @@
+
+// For equal_range comparison.
+struct CompareInsn {
+  bool operator() (const InsnMatchEntry &LHS, StringRef RHS) {
+    return LHS.Format < RHS;
+  }
+  bool operator() (StringRef LHS, const InsnMatchEntry &RHS) {
+    return LHS < RHS.Format;
+  }
+};
+
----------------
rogfer01 wrote:
> This fails to build in Windows with Visual Studio 2013 with debugging enabled because of some debugging macro disaster in the `std::equal_range` used below.
> 
> Do you mind if I add this extra `operator()` like below?
> ```
>   bool operator() (const InsnMatchEntry &LHS, const InsnMatchEntry &RHS) {
> 	  return LHS.Format < RHS.Format;
>   }
> ```
> 
> I know it looks silly but this fails to build from source otherwise when debugging is enabled.
> 
> Thank you
Sure, I don't see anything wrong with that. Sorry for the build break.


Repository:
  rL LLVM

https://reviews.llvm.org/D21809