[PATCH] D23337: [x86, AVX] allow FP vector select folding to bitwise logic ops (PR28895)

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 10 08:22:34 PDT 2016


spatel added a comment.

In https://reviews.llvm.org/D23337#510940, @andreadb wrote:

> Could you please also add extra test cased with ordered comparisons? I am only seeing tests for unordered comparisons in 'select-with-and-or.ll'.


Good point - I lazily copied the existing tests here but only changed the select operands to FP types. I changed the tests to use varying predicates in:
https://reviews.llvm.org/rL278229

Let me know if you see any holes in the coverage - fun mental exercise of translating LLVM predicates to SSE predicates... :)
If there is a bug in that part, it should be independent of this patch.


https://reviews.llvm.org/D23337





More information about the llvm-commits mailing list