[PATCH] D23286: AMDGPU/SI: Propose to redefine image load/store intrinsics

[Nicolai Hähnle via llvm-commits]

nhaehnle added a subscriber: nhaehnle.
nhaehnle added a comment.

I don't know about making vdata (input & output) overloaded. If you do, please at least add a machine instruction verifier that checks the type against dmask.


================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:255
@@ -255,1 +254,3 @@
+   llvm_i1_ty,        // lwe(imm)
+   llvm_i1_ty],       // da(imm)
   []>;
----------------
da does affect how coordinates are interpreted by the TA block, but not in a way that LLVM could extract from the coordinate type, since LLVM cannot know everything it needs to know to do so (it doesn't know the image dimensions).


https://reviews.llvm.org/D23286