[llvm] r278159 - Without explicitly including <string>, I'm getting an error on the new code in this file. Won't present an issue for anyone that isn't having the same trouble as me.

[Mehdi Amini via llvm-commits]

> On Aug 9, 2016, at 1:32 PM, Chris Dewhurst via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: lerochris
> Date: Tue Aug  9 15:32:59 2016
> New Revision: 278159
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=278159&view=rev
> Log:
> Without explicitly including <string>, I'm getting an error on the new code in this file. Won't present an issue for anyone that isn't having the same trouble as me.

It’d be nice to be more explicit about *why* you’re adding a header (i.e. along the line of "add missing include <string> because stoi() is used is this header”).
Otherwise it is impossible to figure if this is legit (Was a bot broken?)

— 
Mehdi


> 
> Modified:
>    llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h
> 
> Modified: llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h?rev=278159&r1=278158&r2=278159&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h (original)
> +++ llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h Tue Aug  9 15:32:59 2016
> @@ -15,6 +15,7 @@
> #define LLVM_EXECUTIONENGINE_JITSYMBOL_H
> 
> #include "llvm/Support/DataTypes.h"
> +#include <string>
> #include <cassert>
> #include <functional>
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits