[PATCH] D23338: [sancov] MachO indirect symbols support.

[Vitaly Buka via llvm-commits]

vitalybuka added a comment.

lgtm


================
Comment at: tools/sancov/sancov.cc:350
@@ +349,3 @@
+          uint32_t N = Sec.reserved1;
+          for (uint32_t J = 0; J < Count && N + J < NIndirectSyms; J++) {
+            uint32_t IndirectSymbol =
----------------
Why not just J < Dysymtab.nindirectsyms

================
Comment at: tools/sancov/sancov.cc:387
@@ -335,4 +386,3 @@
 
-    if (Name == "__sanitizer_cov" || Name == "__sanitizer_cov_with_check" ||
-        Name == "__sanitizer_cov_trace_func_enter") {
+    if (isSanitizerCovCall(Name)) {
       if (!(Symbol.getFlags() & object::BasicSymbolRef::SF_Undefined))
----------------
Can you combine if and fastest test in-front of slowest?

if (!(Symbol.getFlags() & object::BasicSymbolRef::SF_Undefined) &&   isSanitizerCovCall(Name))
  Result.insert(Address);



https://reviews.llvm.org/D23338