[PATCH] D23339: Don't import variadic functions

Piotr Padlewski via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 17:02:23 PDT 2016


Prazek created this revision.
Prazek added reviewers: eraman, mehdi_amini, tejohnson.
Prazek added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

This patch adds IsVariadicFunction bit to summary in order
to not import variadic functions. Inliner doesn't inline
variadic functions because it is hard to reason about it.

This one small fix improves Importer by about 16%
(going from 86% to 100% of imported functions that are
inlined anywhere)
on some spec benchmarks like 'int' and others.

https://reviews.llvm.org/D23339

Files:
  include/llvm/IR/ModuleSummaryIndex.h
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/Transforms/IPO/FunctionImport.cpp
  test/Bitcode/thinlto-function-summary.ll
  test/Transforms/FunctionImport/Inputs/funcimport.ll
  test/Transforms/FunctionImport/funcimport.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23339.67436.patch
Type: text/x-patch
Size: 6658 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160810/03efa04c/attachment.bin>


More information about the llvm-commits mailing list