[PATCH] D22120: Move inline threshold related flags to InlineSimple.cpp

[Easwaran Raman via llvm-commits]

eraman marked 5 inline comments as done.

================
Comment at: lib/Analysis/InlineCost.cpp:1540-1545
@@ +1539,8 @@
+
+// APIs to create InlineParams based on command line flags and/or other
+// parameters. Generally, users of inline cost analysis obtain an InlineParams
+// object through one of these interfaces and pass it to getInlineCost above.
+// Some specialized versions of inliner (such as the pre-inliner) might not
+// want the command line flags to influence the threshold, in which case they
+// might have their own logic to compute InlineParams.
+
----------------
chandlerc wrote:
> This seems like it might be a better fit merged into the comments for the InlineParams class? Certainly it seems like documentation for users rather than implementation documentation.
This also helped me catch some stale comments about InlineParams! 


https://reviews.llvm.org/D22120