[PATCH] D23108: Implemented 132/213/231 forms selection for X86-FMA3-AVX512 opcodes.

Vyacheslav Klochkov via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 15:38:31 PDT 2016


v_klochkov added a comment.

Craig, thank you for the reviewing the changes.
I moved the new files to llvm/lib/Target/X86.


================
Comment at: lib/Target/X86/Utils/X86InstrFMA3Info.cpp:16
@@ +15,3 @@
+#include "X86InstrFMA3Info.h"
+#include "X86InstrInfo.h"
+#include "llvm/Support/ManagedStatic.h"
----------------
craig.topper wrote:
> What are you getting from this header? The Utils library should not depend on anything from the X86CodeGen library. The Utils library exists today to allow X86InstPrinter to print shuffle decoding in llvm-mc which doesn't have the X86CodeGen library.
> 
> So unless this new class is needed by llvm-mc I suggest not including it in the Utils library as it would just be unnecessary bloat on that binary. Just put it in the main X86 directory directory instead.
This include helped me to fix LLVM build errors like ''X86:: is undefined".

The new classes are not needed by llvm-mc, so I moved the new files to llvm/lib/Target/X86 folder.
Thank you.


https://reviews.llvm.org/D23108





More information about the llvm-commits mailing list