[PATCH] D22590: Improve virtual register handling when computing debug information
Adrian Prantl via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 9 10:30:35 PDT 2016
aprantl added a comment.
I'm planning to simplify DbgValueHistoryCalculator in the near future so I'll need all the test coverage I can get :-)
================
Comment at: lib/CodeGen/AsmPrinter/DbgValueHistoryCalculator.cpp:249
@@ -240,2 +248,3 @@
auto CurElem = I++; // CurElem can be erased below.
- if (ChangingRegs.test(CurElem->first))
+ if (TRI->isVirtualRegister(CurElem->first) ||
+ ChangingRegs.test(CurElem->first))
----------------
I can comment out this condition and the test still passes.
https://reviews.llvm.org/D22590
More information about the llvm-commits
mailing list