[PATCH] D23306: Fix bug in DAGBuilder for getelementptr with expanded vector.

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 10:09:48 PDT 2016


mkuper added inline comments.

================
Comment at: test/CodeGen/X86/gep-expanded-vector.ll:1
@@ +1,2 @@
+; RUN: llc < %s -O2 -mcpu=skx
+
----------------
Why does this test require SKX? If we're crashing in the builder - because v64i64 isn't simple - this should crash regardless of feature-set. If you do need AVX512 of some sort, it would be better to specify it explicitly with -mattr.
On the other hand, you probably want to specify a triple - the issue is x86_64-only, right?

================
Comment at: test/CodeGen/X86/gep-expanded-vector.ll:7
@@ +6,3 @@
+entry:
+  %VectorGep7 = getelementptr inbounds %struct.S1*, <64 x %struct.S1**> undef, i64 -2
+  ret void
----------------
Can you modify the test so that it (a) produces some kind of result, and (b) we check that we get the right result (as opposed to just "not crashing")?


https://reviews.llvm.org/D23306





More information about the llvm-commits mailing list