[PATCH] D23281: [LLVMCov] Swapped the line and count columns.

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 09:40:08 PDT 2016


vsk added a comment.

In https://reviews.llvm.org/D23281#509803, @MaggieYi wrote:

> When the line and count columns are swapped, the compiler-rt profile regression tests need to be updated as well. I have added another patch to update the compiler-rt regression tests. Since llvm and compile-rt are in the different repositories, should I commit two patches separately? (This will cause test failures).


I think it would be fine to commit the two patches separately but simultaneously. The bots may go red temporarily, but that won't be alarming if you mention that a follow-up commit in compiler-rt is needed in your commit message.

Do you have a linux machine to test the changes to test/profile/Linux/coverage_*? If not, I can help with that.


https://reviews.llvm.org/D23281





More information about the llvm-commits mailing list