[PATCH] D23108: Implemented 132/213/231 forms selection for X86-FMA3-AVX512 opcodes.

[Craig Topper via llvm-commits]

craig.topper added inline comments.

================
Comment at: lib/Target/X86/Utils/X86InstrFMA3Info.cpp:16
@@ +15,3 @@
+#include "X86InstrFMA3Info.h"
+#include "X86InstrInfo.h"
+#include "llvm/Support/ManagedStatic.h"
----------------
What are you getting from this header? The Utils library should not depend on anything from the X86CodeGen library. The Utils library exists today to allow X86InstPrinter to print shuffle decoding in llvm-mc which doesn't have the X86CodeGen library.

So unless this new class is needed by llvm-mc I suggest not including it in the Utils library as it would just be unnecessary bloat on that binary. Just put it in the main X86 directory directory instead.


https://reviews.llvm.org/D23108