[PATCH] D23275: [test-suite] Fix adding the halide runtime file as cxx after file renaming.

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 16:48:41 PDT 2016


LGTM.

(At this point, I think you should just commit such simple fixes and skip pre-commit review, and keep an eye on the bots)

> On Aug 8, 2016, at 10:17 AM, Alina Sbirlea <asbirlea at google.com> wrote:
> 
> asbirlea created this revision.
> asbirlea added a reviewer: MatzeB.
> asbirlea added subscribers: llvm-commits, mehdi_amini.
> Herald added a subscriber: aemerson.
> 
> In order for the bitcode files to be linked they need to be marked as being cxx language.
> A previous patch renaming the halide runtime failed to do the renaming in the cmake file.
> This should also fix the problem of failing aarch64 tests on green dragon - to be re-enabled after this fix.
> 
> https://reviews.llvm.org/D23275
> 
> Files:
>  Bitcode/simd_ops/CMakeLists.txt
> 
> Index: Bitcode/simd_ops/CMakeLists.txt
> ===================================================================
> --- Bitcode/simd_ops/CMakeLists.txt
> +++ Bitcode/simd_ops/CMakeLists.txt
> @@ -3,7 +3,7 @@
> SET_SOURCE_FILES_PROPERTIES(${uosources} PROPERTIES LANGUAGE CXX)
> file(GLOB scalar_sources ${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_scalar_tests/*.bc)
> SET_SOURCE_FILES_PROPERTIES(${scalar_sources} PROPERTIES LANGUAGE CXX)
> -SET_SOURCE_FILES_PROPERTIES(${CMAKE_CURRENT_SOURCE_DIR}/simd_op_check_runtime.bc PROPERTIES LANGUAGE CXX)
> +SET_SOURCE_FILES_PROPERTIES(${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_halide_runtime.bc PROPERTIES LANGUAGE CXX)
> 
> list(APPEND LDFLAGS -lpthread -ldl)
> add_library(simd_ops STATIC simd_ops.cpp ${ARCH}_halide_runtime.bc)
> 
> 
> <D23275.67196.patch>



More information about the llvm-commits mailing list