[PATCH] D23256: Teach the analysis manager about inter-analysis dependencies.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 15:08:52 PDT 2016


silvas added a comment.

In https://reviews.llvm.org/D23256#508756, @davidxl wrote:

> May I suggest a way to do reduce the diff?
>
> 1. first do a nfc change with
>
>   typedef AnalysisManager<Function> FuncAnalysisManager; ....
>
>   and replace all AnalysisManager<function> with the typedef
> 2. after that is in, this patch can be simplified with typedef AnalysisManager FuncAnalysisManager; ...
> 3. if 2) goes in, do another NFC to remove the typedef.


Good suggestion. I'll try that (we already have the typedef's. We just don't use them consistently)


https://reviews.llvm.org/D23256





More information about the llvm-commits mailing list