[PATCH] D23254: CodeView: extract the OMF Directory Header

[Saleem Abdulrasool via llvm-commits]

compnerd planned changes to this revision.

================
Comment at: lib/DebugInfo/CodeView/CVDebugRecord.cpp:14-21
@@ +13,10 @@
+
+const support::ulittle32_t OMF::Signature::PDB70Signature =
+    support::ulittle32_t(0x53445352); // RSDS
+const support::ulittle32_t OMF::Signature::PDB20Signature =
+    support::ulittle32_t(0x3031424e); // NB10
+const support::ulittle32_t OMF::Signature::CV50Signature =
+    support::ulittle32_t(0x3131424e); // NB11
+const support::ulittle32_t OMF::Signature::CV41Signature =
+    support::ulittle32_t(0x3930424e); // NB09
+
----------------
majnemer wrote:
> This is pretty irregular, we usually have the constant have a normal type.  I would expect this to be an enum.
I didnt consider making that an enum.  I like that better.  Ill change this.


Repository:
  rL LLVM

https://reviews.llvm.org/D23254