[PATCH] D23167: emit_DW_AT_noreturn flag

[Adrian Prantl via llvm-commits]

aprantl added a comment.

Thanks, now all that's missing is an LLVM IR round-trip test. Adding the new flag to test/Assembler/disubprogram would work.


================
Comment at: test/DebugInfo/noreturn_c11.ll:9
@@ +8,3 @@
+
+; CHECK:                      DW_AT_noreturn
+
----------------
Maybe check for just a bit more context (the DW_TAG_subprogram + DW_AT_name should be fine)?

================
Comment at: test/DebugInfo/noreturn_c11.ll:29
@@ +28,3 @@
+
+attributes #0 = { noreturn nounwind uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { noreturn nounwind "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
We typically strip out all unnecessary attributes to not distract from the testcase. A good heuristic is that you can usually get rid of everything in quotes.

================
Comment at: test/DebugInfo/noreturn_cpp11.ll:9
@@ +8,3 @@
+
+; CHECK:                      DW_AT_noreturn
+
----------------
More context.

================
Comment at: test/DebugInfo/noreturn_cpp11.ll:36
@@ +35,3 @@
+
+attributes #0 = { noreturn uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind }
----------------
Strip attributes.

================
Comment at: test/DebugInfo/noreturn_objc.ll:10
@@ +9,3 @@
+; }
+
+; CHECK:                      DW_AT_noreturn
----------------
more context

================
Comment at: test/DebugInfo/noreturn_objc.ll:31
@@ +30,3 @@
+
+attributes #0 = { noreturn nounwind uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { noreturn nounwind "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
strip attributes


https://reviews.llvm.org/D23167