[PATCH] D22112: Disambiguate a constant with both 0B prefix and H suffix.

[Colin LeMahieu via llvm-commits]

colinl added inline comments.

================
Comment at: lib/MC/MCParser/AsmLexer.cpp:261
@@ +260,3 @@
+  // MASM-flavor hexadecimal integer: [0-9][0-9a-fA-F]*[hH]
+  if (IsParsingMSInlineAsm && isdigit(CurPtr[-1])) {
+    const char *FirstNonBinary = (CurPtr[-1] != '0' && CurPtr[-1] != '1') ?
----------------
Will CurPtr ever be at the beginning of the buffer, making index -1 invalid?

================
Comment at: tools/clang/test/CodeGenCXX/ms-inline-asm-return.cpp:88
@@ -87,3 +87,3 @@
 // CHECK-LABEL: define i64 @f_s8()
-// CHECK: %[[r:[^ ]*]] = call i64 asm sideeffect inteldialect "mov eax, $$0x01010101\0A\09mov edx, $$0x01010101", "=A,~{eax},{{.*}}"
+// CHECK: %[[r:[^ ]*]] = call i64 asm sideeffect inteldialect "mov eax, $$16843009\0A\09mov edx, $$16843009", "=A,~{eax},{{.*}}"
 // CHECK: store i64 %[[r]], i64* %{{.*}}
----------------
What made these switch from printing hex to decimal?


https://reviews.llvm.org/D22112