[PATCH] D23201: [ELF] - Fix for: error "invalid section index: xxx" when linking FreeBSD kernel.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 10:31:47 PDT 2016


davide added a comment.

In https://reviews.llvm.org/D23201#508362, @grimar wrote:

> In https://reviews.llvm.org/D23201#507140, @davide wrote:
>
> > testcase?
>
>
> hpt27xx_lib.o file used in bug is prebuilt and has about 1.1mb size.  I do not know way to reduce it or to produce
>  smaller sample. Should I use it or we can just rely on the fact that the change works for linking it in BSD world ?


No. Not quite. We don't have a FreeBSD buildbot that does CI and even if we had it this code can break at any time and it will require somebody (likely me or Ed Maste) to ask for a revert. Please take the time to reduce this test case.


https://reviews.llvm.org/D23201





More information about the llvm-commits mailing list