[PATCH] D23205: [LVI] Make LVI smarter about comparisons with non-constants

[Sanjoy Das via llvm-commits]

sanjoy added a comment.

lgtm!


================
Comment at: lib/Analysis/LazyValueInfo.cpp:1205
@@ +1204,3 @@
+  // of:
+  //  icmp Val, ...
+  //  icmp ult (add Val, Offset), ...
----------------
apilipenko wrote:
> No, this code can handle any predicate. 
> 
> The predicate limitation for icmp ult (add Val, Offset), ... conditions is somewhat artificial it comes from the existing code. As a separate change I'm going to support arbitrary predicates for conditions in this form as well.
In that case, I think

```
icmp <pred> Val, ...
```

will be clearer.


https://reviews.llvm.org/D23205