[PATCH] D23166: [X86] Improve code size on X86 segment moves

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm I'm OK doing what gas does here for now.


================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:2346
@@ +2345,3 @@
+         X86MCRegisterClasses[X86::GR32RegClassID].contains(Op1.getReg()))) {
+      // fix name
+      if (Name != "mov" && Name[3] == (is16BitMode() ? 'l' : 'w')) {
----------------
Please make this and the comment below complete sentences.

================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:2352
@@ +2351,3 @@
+      // select correct register
+      unsigned reg =
+          getX86SubSuperRegisterOrZero(Op1.getReg(), is16BitMode() ? 16 : 32);
----------------
s/reg/Reg/


https://reviews.llvm.org/D23166