[PATCH] D23249: Refactor getMipsEFlags.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 7 14:50:16 PDT 2016


ruiu created this revision.
ruiu added a reviewer: atanasyan.
ruiu added a subscriber: llvm-commits.
Herald added a subscriber: sdardis.

Previously, we incrementally updated the reuslting flag as we check
file flags, so it was not very clear who is updating what flags.
This patch makes them pure functions -- that has no side effect and
don't update arguments to improve readability.

Now each function construct a patial result, and all resutls are then
bitwise-OR'ed to construct the final result.

This patch also creates a new file, Mips.cpp, to move all these
MIPS functions to a separate file.

https://reviews.llvm.org/D23249

Files:
  ELF/CMakeLists.txt
  ELF/Mips.cpp
  ELF/Writer.cpp
  ELF/Writer.h
  test/ELF/mips-elf-flags-err.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23249.67104.patch
Type: text/x-patch
Size: 14012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160807/0487b068/attachment.bin>


More information about the llvm-commits mailing list