[PATCH] D23228: [libcxxabi] Do not depend on unwind when building standalone

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 6 16:35:28 PDT 2016


phosek added a comment.

It does not imply that `libunwind.(so|a)` is unavailable, but it does imply that CMake target `unwind` is unavailable because we're building libcxxabi as a standalone project. `LIBCXXABI_TEST_DEPS` is passed to `check-libcxxabi` as `DEPENDS` argument which is translated to `add_dependencies` invocation which is incorrect. `add_lit_testsuite` generates the rule for invoking `lit`, it does not actually generate the build rule, so `target_link_libraries` in this case would be also incorrect.


Repository:
  rL LLVM

https://reviews.llvm.org/D23228





More information about the llvm-commits mailing list