[PATCH] D23056: Adding test for DIMacro and DIMacroFile comparison implementation

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 6 13:39:54 PDT 2016


aaboud added a comment.

In https://reviews.llvm.org/D23056#504984, @dblaikie wrote:

> Ah, thanks - OK, so the issue was that the second DICompileUnit ended up sharing the first's DIMacroFile.


I just noticed that you got me wrong.
The issue is that the second DICimpileUnit ended up **not** sharing the first's DIMacroFile.

Anyway, I will try improve the test using the above as an example.


https://reviews.llvm.org/D23056





More information about the llvm-commits mailing list